Merged
Conversation
Contributor
dopplershift
left a comment
dopplershift
left a comment
There was a problem hiding this comment.
This seems reasonable enough to me. Do we need to update the docs somewhere about this? Or can we mention it if it’s not already there?
Contributor
|
This seems good to me too, not sure why it isn't installed already. Can you rebase to resolve the conflicts? |
4 tasks
Member
|
You'll need to update CI for the name change. |
stefraynaud
force-pushed
the
download_feature_as_script
branch
from
b25eea8 to
a1052d0
Compare
Rename it to cartopy_feature_download.py and add it to setup.py to make it installable. Rm unattended .travis.yml Fix ci for feature download
stefraynaud
force-pushed
the
download_feature_as_script
branch
from
a1052d0 to
ef74262
Compare
Contributor
Author
|
It's ok,there now. |
This was referenced Sep 3, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale
Rename
feature_download.pytocartopy_feature_download.pyand add it to setup.py to make it installable.I prefixed it with
cartopy_to make it clear that it is a cartopy tool.Implications
Once cartopy is installed, the user has a direct access to
cartopy_feature_download.pyto install new features, without having to search for this script.